Repository navigation
fix(identity): restore generic identity overloads - #399
Merged
Merged
Conversation
- Restore the sixteen SQL Server and SQLite TUser/TRole overloads released in 4.1.0 while retaining current factory APIs. - Preserve exact signatures with justified method-level SST2307 exceptions and keep singleton context options consistent. - Add thirty-two TUnit compatibility cases for custom users, roles, service lifetimes, and fluent registration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix restoring the generic Identity overloads accidentally removed in #364 and released without them in 5.0.0.
What is the new behavior?
SQL Server and SQLite again expose all sixteen 4.1.0 overloads for custom
TUserand optionalTRole, throughIHostApplicationBuilderandIServiceCollection, with default and explicit context lifetimes. Existing factory/delegate APIs remain available.The restored declarations preserve the exact historical signatures. Method-level SST2307 exceptions document why callers must explicitly supply their Identity types. Context constructor preservation is annotated, and singleton contexts receive singleton options so scope validation succeeds.
What is the current behavior?
The generic user/role overloads are missing, forcing callers to replace previously valid registrations with factory and Identity configuration delegates.
Checklist
Additional information
-warnaserror: zero warnings and errors across all target frameworks.v4.1.0tag; none are missing or changed.